drivers: i2s: stm32 sai add support for stm32f4xx series #97829
+121
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariopaja
force-pushed
the
stm32f4xx_sai
branch
from
aa80eee to
5ba3553
Compare
21 tasks
mariopaja
force-pushed
the
stm32f4xx_sai
branch
from
5ba3553 to
900fbe6
Compare
These changes enable SAI1 A & B nodes in STM32F4xx series. Signed-off-by: Mario Paja <[email protected]>
STM32F4xx series shares several DMA configurations with the other platforms. These changes aim to enable platform specific DMA configuration and align them to other platforms. Signed-off-by: Mario Paja <[email protected]>
Add nucleo_f429zi board in samples/drivers/i2s/output Signed-off-by: Mario Paja <[email protected]>
mariopaja
force-pushed
the
stm32f4xx_sai
branch
from
900fbe6 to
cc72746
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
zephyrbot
added
platform: STM32
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
JarmouniA,
TomasBarakNXP,
anangl,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
kartben,
marwaiehm-st,
mathieuchopstm and
nashif
erwango
approved these changes
Oct 20, 2025
gautierg-st
reviewed
Oct 20, 2025
Comment on lines
320
to
+322
| #if !defined(CONFIG_SOC_SERIES_STM32H7X) && !defined(CONFIG_SOC_SERIES_STM32L4X) && \ | ||
| !defined(CONFIG_SOC_SERIES_STM32G4X) && !defined(CONFIG_SOC_SERIES_STM32L5X) | ||
| !defined(CONFIG_SOC_SERIES_STM32G4X) && !defined(CONFIG_SOC_SERIES_STM32L5X) && \ | ||
| !defined(CONFIG_SOC_SERIES_STM32F4X) |
There was a problem hiding this comment.
Could we replace all these defined with a single #if DT_HAS_COMPAT_STATUS_OKAY(st_stm32u5_dma) ?
That would probably make adding other series easier.
There was a problem hiding this comment.
I will do it on a separate PR after F7 is merged (and then I am node with almost all series), It is already in todo :)
Comment on lines
331
to
+333
| #if !defined(CONFIG_SOC_SERIES_STM32H7X) && !defined(CONFIG_SOC_SERIES_STM32L4X) && \ | ||
| !defined(CONFIG_SOC_SERIES_STM32G4X) && !defined(CONFIG_SOC_SERIES_STM32L5X) | ||
| !defined(CONFIG_SOC_SERIES_STM32G4X) && !defined(CONFIG_SOC_SERIES_STM32L5X) && \ | ||
| !defined(CONFIG_SOC_SERIES_STM32F4X) |
Comment on lines
352
to
+354
| #elif !defined(CONFIG_SOC_SERIES_STM32H7X) && !defined(CONFIG_SOC_SERIES_STM32L4X) && \ | ||
| !defined(CONFIG_SOC_SERIES_STM32G4X) && !defined(CONFIG_SOC_SERIES_STM32L5X) | ||
| !defined(CONFIG_SOC_SERIES_STM32G4X) && !defined(CONFIG_SOC_SERIES_STM32L5X) && \ | ||
| !defined(CONFIG_SOC_SERIES_STM32F4X) |
Comment on lines
293
to
+295
| #if defined(CONFIG_SOC_SERIES_STM32H7X) || defined(CONFIG_SOC_SERIES_STM32L4X) || \ | ||
| defined(CONFIG_SOC_SERIES_STM32G4X) || defined(CONFIG_SOC_SERIES_STM32L5X) | ||
| defined(CONFIG_SOC_SERIES_STM32G4X) || defined(CONFIG_SOC_SERIES_STM32L5X) || \ | ||
| defined(CONFIG_SOC_SERIES_STM32F4X) |
There was a problem hiding this comment.
And here we could maybe use #if DT_HAS_COMPAT_STATUS_OKAY(st_stm32_dma_v1) || DT_HAS_COMPAT_STATUS_OKAY(st_stm32_dma_v2) ?
Comment on lines
469
to
+470
| /* Control of MCLK output from SAI configuration is not possible on STM32L4xx MCUs */ | ||
| #if !defined(CONFIG_SOC_SERIES_STM32L4X) | ||
| #if !defined(CONFIG_SOC_SERIES_STM32L4X) && !defined(CONFIG_SOC_SERIES_STM32F4X) |
There was a problem hiding this comment.
Comment is outdated (missing F4). This could be replaced with #ifdef SAI_MCK_OUTPUT_ENABLE to avoid having to add other series in future.
| } | ||
|
|
||
| hdma->Instance = STM32_DMA_GET_INSTANCE(stream->reg, stream->dma_channel); | ||
| #if defined(CONFIG_SOC_SERIES_STM32F4X) |
There was a problem hiding this comment.
Here it could probably be #ifdef DMA_CHANNEL_1.
| #endif | ||
|
|
||
| #if defined(CONFIG_SOC_SERIES_STM32H7X) | ||
| #if defined(CONFIG_SOC_SERIES_STM32H7X) || defined(CONFIG_SOC_SERIES_STM32F4X) |
There was a problem hiding this comment.
And here #ifdef DMA_FIFOMODE_DISABLE
Comment on lines
483
to
+484
| /* MckOverSampling is not supported by all STM32L4xx MCUs */ | ||
| #if !defined(CONFIG_SOC_SERIES_STM32L4X) | ||
| #if !defined(CONFIG_SOC_SERIES_STM32L4X) && !defined(CONFIG_SOC_SERIES_STM32F4X) |
There was a problem hiding this comment.
Same here. Could be replaced with #ifdef SAI_MCK_OVERSAMPLING_DISABLE
gautierg-st
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables SAI on STM32F4xx series by:
Audio Test:
2CH, 16bit, 44.1KHz, PCM5102a
stm32f4xx_sai.mp4